Code review comment for lp:~edwin-grubbs/launchpad/bug-412519-team-page

Revision history for this message
Martin Albisetti (beuno) wrote :

Thank you for your changes, the page is looking much better. Great job.

Fixing the major problems it had has, however, brought some of the "polish" issues to my attention I would like to solve on this page, so, if you can still invest a bit of time on this page, please try and address them.

- I'd drop mentoring from that page. The feature is broken.
- How about s/Recently applied/Pending approval?
- If there's no email set, we should probably say "set contact email" instead of edit
- If there is an email set, just have an edit icon next to it, no text
- The "join team" should be placed before the actions portlet, just like downloads
- If there's no mailing list, it should say "create a mailing list", with an add icon
- I'd move the "show members photos" link into +members, uncluttering that section
- "You are not a member of this team" should probably be preceded by "(+) Join it". I'd also add some spacing between this text and the rest (0.5-1em, see what feels right)
- s/Mailing list archive/View archive
- s/Mailing list subscribers/View subscribers
- s/You are not subscribed to the team mailing list. (Subscribe)/(+) Subscribe to mailing list

review: Needs Fixing (ui)

« Back to merge proposal