Code review comment for lp:~edwin-grubbs/launchpad/bug-490659-series-timeout
Revision history for this message
| Edwin Grubbs (edwin-grubbs) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Hi Edwin,
>
> Interesting branch!
>
> typo: substitude -> substitute
Fixed both the db function and the code that I stole that from.
> Should has_milestones be exported?
I think it would be better not to slow down every query for the pillars and series by adding another attribute that is hardly ever used. The other milestones attributes are references to collections, so you don't actually invoke the extra query unless you follow that link.
> Any reason you cannot use ISlaveStore for the queries?
IStore() chooses the slave or master based on whether the user has modified anything lately. If I forced it to use ISlaveStore, it would not show the user any changes they made until they propagated to the slave servers.