Code review comment for lp:~edwin-grubbs/launchpad/bug-535430-needspackaging-timeout-part1
Revision history for this message
| Edwin Grubbs (edwin-grubbs) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Ok, removing the trigger makes it easier to keep things sane. How do you
> intend to keep the other values up-to-date?
The other values will be kept up-to-date with a cronjob.
> Maybe it makes sense to rename
> them, so that it's clear that they are caches only, and might not be correct?
> Unless you find a way of making sure they are up to date, of course.
Although I was originally thinking of updating the values with a cronjob, the max_bug_heat is currently updated with a hook in addTask(), so it would be easy to add that. I assume that I could do something similar for po_message_count.
> Also, for
> the bug values, will it include private bugs as well?
Yes.
> The comments should be added to comments.sql.
The comments have been moved.