Code review comment for lp:~edwin-grubbs/launchpad/bug-597738-bug-service-status

> Hi Edwin, et al.
>
> I have some concerns about the consistency of the unknown/external/lp
> states for all bug targets and some of their states. I think we need to
> address all of these and I think we need to plan one or more branches to
> complete the bugs app front page for bugtargets
>
> (distro) https://bugs.launchpad.dev/kubuntu as Admin
>
> I see a message about forwarding bugs, but I know distros cannot
> have remote bug trackers. The choice is Launchpad or does not use
> Launchpad. The current message is better

I have added a conditional to display the old message if the context cannot have an external bug tracker.

> This is a fair example of why we do not use context/title inline.
>
> I see "_Enable bug tracking._" I think there should be an edit icon
> preceding it.

I have added the sprite to this link.

> (dsp) https://bugs.launchpad.dev/kubuntu/+source/mozilla-firefox
>
> Oh my! This implies kubuntu does use bugs. I get an oops if I try to
> report bug.
> /me looks at fedora on lpnet.
> https://bugs.edge.launchpad.net/fedora/+source/mozilla-firefox
> also prompts me to report a bug and it too oopses :(
> ^ This is a separate issue but this is exactly the kind of
> mis-communication we are trying to fix. bridging the grape is not
> done until we address this.
> https://bugs.edge.launchpad.net/malone/+bug/635302

The DSP's default view is +bugs instead of +bugs-index, so it has no logic to inform the user that Launchpad doesn't track bugs for the DSP.

> (project) https://bugs.launchpad.dev/gnome-terminal with bug tracker
>
> Looks good.
>
> (project) https://bugs.launchpad.dev/thunderbird after linking to two packages
>
> I see
> Launchpad keeps track of bug reports for _cnews in ubuntu_,
> _pmount in ubuntu_.
> which is very odd. Some projects produce 20 packages and some have
> names nothing like the upstream project in Lp. I am not sure Launchpad
> is tracking this bugs, Ubuntu is. Maybe
> Ubuntu tracks bugs related to packages derived from this project:
> _cnews in ubuntu_, _pmount in ubuntu_.

I have made that change to the wording.

> (project group) https://bugs.launchpad.dev/launchpad-mirrors
>
> Implies the project groups has projects that track bugs. This is not
> True. The page should state that none of the group's project use
> Launchpad to track bugs. There is nothing to configure since the behaviour
> is derived from the state of member projects. The answers app tells the
> user that Lp does not know where support is managed.

Just like DSPs, ProjectGroups use +bugs instead of +bugs-index, so it will take some work in a later branch to fix.

> > === modified file 'lib/lp/bugs/templates/bugtarget-bugs.pt'
> > --- lib/lp/bugs/templates/bugtarget-bugs.pt 2010-08-04 11:01:15 +0000
> > +++ lib/lp/bugs/templates/bugtarget-bugs.pt 2010-09-10 14:33:54 +0000
> > ...
> >
> > @@ -162,27 +166,55 @@
> >
> > <p id="no-bugs-report"><a href="+filebug">Report a bug.</a></p>
> > </tal:no_hot_bugs>
> > - </tal:uses_malone>
> > -
> > - <tal:not_uses_malone condition="not: view/uses_launchpad_bugtracker"
> > - tal:define ="configure_bugtracker
> context/menu:overview/configure_bugtracker | nothing">
> > - <p id="no-malone"><strong><tal:project_title replace="context/title"
> /> does not use Launchpad for
> > - bug tracking.</strong></p>
> > - <p tal:condition="view/external_bugtracker"
> > - id="bugtracker"><strong>Bugs are tracked in
> > - <tal:bugtracker replace="structure view/bugtracker"
> />.</strong>
> > - </p>
> > -
> > - <p tal:condition="context/required:launchpad.Edit"
> > - id="no-malone-edit"
> > - >
> > - <a tal:condition="configure_bugtracker"
> > - tal:replace="structure configure_bugtracker/fmt:link"/>
> > - <a tal:condition="not: configure_bugtracker"
> > - tal:attributes="href string:${context/fmt:url/+edit}">
> > - Enable bug tracking.</a>
> > - </p>
> > - </tal:not_uses_malone>
> > + </tal:uses_launchpad_bugtracker>
> > +
> > + <p id="no-malone"
> > + tal:condition="view/bug_tracking_usage/enumvalue:UNKNOWN">
> > + <strong>
> > + Launchpad does not know where to forward bug reports to contact the
> > + developers of <tal:project_title replace="context/title" />.
> > + </strong>
> > + </p>
>
> context.title is deprecated. It was intended for page titles only and we
> want to remove it because it has only one use and users put sentences in
> the field. Use displayname, which is intended for inclusion in sentences.

I switched context/title to context/displayname. The only downside is that the context/displayname for project series is lowercase, e.g. "trunk", whereas the context/title was something like "Bazaar trunk series".

> > + <p tal:condition="view/external_bugtracker"
> > + id="bugtracker">
> > + <strong>Bugs are tracked in
> > + <tal:bugtracker replace="structure view/bugtracker" />.
> > + </strong>
> > + </p>
> > +
> > + <tal:also_in_ubuntu
> > + condition="not: view/bug_tracking_usage/enumvalue:LAUNCHPAD">
> > + <p tal:define="packages context/ubuntu_packages | nothing"
> > + tal:condition="packages"
> > + id="also-in-ubuntu">
> > + Launchpad
> > + <tal:also condition="view/external_bugtracker">also</tal:also>
> > + keeps track of bug reports for
> > + <tal:packages repeat="package packages">
> > + <span style="white-space: nowrap"
> > + tal:content="structure package/fmt:link" /><tal:comma
> > + condition="not:repeat/package/end">,</tal:comma></tal:packages>.
> > + </p>
> > + </tal:also_in_ubuntu>
> > +
> > + <div
> > + tal:condition="not: view/bug_tracking_usage/enumvalue:LAUNCHPAD"
> > + tal:define="configure_bugtracker
> context/menu:overview/configure_bugtracker | nothing">
> > + <a class="sprite maybe"
> > + href="https://help.launchpad.net/Bugs">Getting started
> > + with bug tracking in Launchpad</a>.
> > +
> > + <p tal:condition="context/required:launchpad.Edit"
> > + id="no-malone-edit"
> > + >
> > + <a tal:condition="configure_bugtracker"
> > + tal:replace="structure configure_bugtracker/fmt:link"/>
> > + <a tal:condition="not: configure_bugtracker"
> > + tal:attributes="href string:${context/fmt:url/+edit}">
> > + Enable bug tracking.</a>
>
> Should this last link be?
> <a class="sprite edit"
> tal:condition="not: configure_bugtracker"
> tal:attributes="href structure context/menu:overview/edit/fmt:link">
> Enable bug tracking.</a>

This has been fixed.

> > I think that getting rid of the text looks cleaner than integrating it with
> > the help link, but I don't know how important it is to explain that "offering
> > support" means tracking questions and creating FAQs.
>
> Instead of support, maybe we should just say "questions and FAQs", because that is what we want to > know. I will be adding fields for mailing lists and forums for answers in my after hours, so I
> expect the external page will clearly state where the user can find the answers to his or
> her questions.

I updated the link text.