Code review comment for lp:~edwin-grubbs/lazr-js/activator-ie-fixes

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Summary
-------

This branches gets the Activator working 100% in IE7&8, Webkit, and Opera.

Implementation details
----------------------

Added disableTabIndex() function.
    src-js/lazrjs/lazr/lazr.js
    examples/lazr/index.html
    src-js/lazrjs/activator/activator.js
    src-js/lazrjs/inlineedit/editor.js

Fixed all lint errors after discovering that some
of them were breaking IE, because this file becomes
part of the one big consolidated javascript file.
    src-js/lazrjs/testing/testing.js

Fixed tests to run in IE7&8, Webkit, and Opera.
    src-js/lazrjs/activator/tests/activator.js

Updated the tests for the new behavior of disableTabIndex().
This still does not pass all the tests in IE or Opera.
    src-js/lazrjs/inlineedit/tests/inline_edit.js

Display fix for opera.
    examples/activator/index.html

Fix an IE7 issue centering a div.
    src-js/lazrjs/activator/assets/skins/sam/activator-skin.css

Tests
-----

file:///.../src-js/lazrjs/activator/tests/activator.html

or use ./bin/test to run the full suite with jstestdriver.

Demo and Q/A
------------

* Open file:///.../examples/activator/index.html

« Back to merge proposal