Code review comment for lp:~eric97/bzr/dump-btree-api

Revision history for this message
Vincent Ladeuil (vila) wrote :

Nicely done !
Just one tweak from me but good to land otherwise:

151 + test_raw_output_3nodes = (
152 + 'Root node:\n'
153 + 'B+Tree Graph Index 2\n'

You can just use:

test_raw_output_3nodes = '''Root node:
B+Tree Graph Index 2
...
'''

Or even:

test_raw_output_3nodes = '''\
Root node:
B+Tree Graph Index 2
...
'''

Easier to copy/paste (all rules have exceptions, copy/paste is bad, but copying an expected result from a failed test is way faster than typing it from scratch).

Nice to see tests going from blackbox to unit !

I let our PP do the second review ;)

review: Approve

« Back to merge proposal