Code review comment for lp:~eric97/bzr/mutter-pid

On 8 January 2011 09:26, John A Meinel <email address hidden> wrote:
>> On the other hand, I could back part-way out, and add *only* the PID to mutter() lines.  That would produce format #4:
>>     [21703] 1.234  Plugin name launchpad already loaded
>>     [21703] 2011-01-07 19:07:18.974 WARNING: bzr: warning: blah
>>
>> which is shorter, but violates your "more in common" request.
>
> ^- This is my personal favorite. mutter lines are far more common than
> warning/error lines.
>
> I don't find the absolute date-time to be very useful, when with
> pid+elapsed time+log at startup time you can get it if you need to.
>
> [PID] has some real use cases for sorting out which lines belonged to
> which process. So I'm in favor of adding it.

Same here. The word "warning" has some meaning to the user to say
that it's not been fatal etc, but "mutter" is just a random internal
bit.

Possibly we should only log the full time when it's for say a server
log, and then it should probably go to syslog. For the common cases
of just .bzr.log it should not run long enough to matter.

Thanks
--
Martin