On Sun, Nov 11, 2012 at 02:57:19PM -0000, Daniel Hartwig wrote:
> Please reconsider this change:
>
> * Hide the only download packages checkbox if there are no files
> to download (LP: #413453)
>
> because it may still be enabled from a previous run (see ::showAndConfirm). The check for “download size is nil” is too simple. You also do *not* want to automagically unset this some times and not others, this is very disruptive behaviour.
>
> To keep things simple, I suggest to revert this change and close the associated bug.
Thanks Daniel, I think this is a valid concern, I reverted this for
now. I hope that is ok with you Robert, please let me know if you have
any alternative ideas, but it seems like its a relatively small change.
On Sun, Nov 11, 2012 at 02:57:19PM -0000, Daniel Hartwig wrote:
> Please reconsider this change:
>
> * Hide the only download packages checkbox if there are no files
> to download (LP: #413453)
>
> because it may still be enabled from a previous run (see ::showAndConfirm). The check for “download size is nil” is too simple. You also do *not* want to automagically unset this some times and not others, this is very disruptive behaviour.
>
> To keep things simple, I suggest to revert this change and close the associated bug.
Thanks Daniel, I think this is a valid concern, I reverted this for
now. I hope that is ok with you Robert, please let me know if you have
any alternative ideas, but it seems like its a relatively small change.
Cheers,
Michael