Code review comment for lp:~flacoste/launchpad/bug-129943

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Thanks for the review.

I've fixed the typo.

The port number was changed because 8089 conflicts with Banshee DAAP locally. Since it might burn other folks too, I decided to commit it.

Even though python-feedparser is a pretty static dependancy, I'd really not want to block on a l-d-d update to land this branch. If you insist, I could add it to the launchpad-dependencies, so that the next deployment of it, would pull it off and use it instead of the one in the download-cache. I would not ask LOSA to go to the trouble of building new buildbot images and deploy these two packages across all app servers for that dependency.

« Back to merge proposal