Code review comment for lp:~flacoste/launchpad/bug-559128

On April 15, 2010, Francis J. Lacoste wrote:
> On April 15, 2010, Gary Poster wrote:
> > A niggle, but I found it a bit odd when ``setupInteractionForPerson``
> > called ``return setupInteractionByEmail(ANONYMOUS, participation)``. I
> > wondered why I should call a function with the word "email" in it to get
> > an interaction when there's no email involved. My preference would be to
>
> > change setupInteraction to look like this:
> Well, I guess, I could call setupInteraction directly in that case. I'll do
> this.
>
> > def setupInteraction(principal, login=None, participation=None):
> > """Sets up a new interaction with the given principal.
>
> This changes the signature of the function. I'll pass on it since I don't
> feel like chasing all the call sites :-)
>
> Cheers

Disregard this, your suggestion makes perfect sense and I'll implement it.

/me shouldn't reply before the context restore has finished...

--
Francis J. Lacoste
<email address hidden>