A4

Code review comment for lp:~francesco-marella/a4/i18n

Revision history for this message
Andrea Gasparini (gaspa) wrote :

The old functionalities are ok, and strings are correct. Unfortunately I don't know enough the translation engine to make further tests, but to me the code is ok.

Just one remark (and a note for the merger), we usually try to keep the code clean with some tools.
A brief test with pep8 gives:
a4lib/i18n.py:12:1: E302 expected 2 blank lines, found 1
(It's just one blank line, I guess the one of us that will merge can correct this as well)

review: Approve

« Back to merge proposal