Code review comment for lp:~free.ekanayaka/charms/trusty/haproxy/advertise-public-ip

Revision history for this message
Chris Glass (tribaal) wrote :

Thanks for the proposed change, the functionality looks good and is useful, however I would like to see the exposed certificate updated in case it changes after initial deployment before I can +1 this branch.

Furthermore:

[0] Please add some human documentation for this change in the README file.

Thanks!

review: Needs Fixing

« Back to merge proposal