update-notifier-kde

Merge lp:~freinhard/update-notifier-kde/respect-exitcodes into lp:update-notifier-kde

  1. respect-exitcodes
  2. Merge into trunk
Proposed by Florian Reinhard
Status: Merged
Merge reported by: Harald Sitter
Merged at revision: not available
Proposed branch: lp:~freinhard/update-notifier-kde/respect-exitcodes
Merge into: lp:update-notifier-kde
Diff against target: None lines
To merge this branch: bzr merge lp:~freinhard/update-notifier-kde/respect-exitcodes
Reviewer Review Type Date Requested Status
Harald Sitter Approve
Jonathan Riddell Pending
Review via email: mp+12028@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Harald Sitter (apachelogger) wrote :

Good to go IMHO

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'update-notifier-kde.py'
--- update-notifier-kde.py 2009-06-17 15:57:57 +0000
+++ update-notifier-kde.py 2009-06-18 15:37:38 +0000
@@ -414,7 +414,6 @@
414414
415 def codecsActivated(self):415 def codecsActivated(self):
416 """ user wants to install, show dialogue and install """416 """ user wants to install, show dialogue and install """
417 self.codecsTray.hide()
418 dialogue = KDialog()417 dialogue = KDialog()
419 dialogue.setButtons(KDialog.ButtonCode(KDialog.Ok | KDialog.Cancel))418 dialogue.setButtons(KDialog.ButtonCode(KDialog.Ok | KDialog.Cancel))
420 dialogue.setButtonText(KDialog.Ok, i18n("Install Selected"))419 dialogue.setButtonText(KDialog.Ok, i18n("Install Selected"))
@@ -455,7 +454,9 @@
455 self.process.start()454 self.process.start()
456455
457 def processFinished(self, exitCode, exitStatus):456 def processFinished(self, exitCode, exitStatus):
458 KNotification.event("Restricted", i18n("You will need to restart %1 to use the new functionality", self.application), KIcon("system-software-update").pixmap(QSize(22,22)))457 if not exitCode:
458 self.codecsTray.hide()
459 KNotification.event("Restricted", i18n("You will need to restart %1 to use the new functionality", self.application), KIcon("system-software-update").pixmap(QSize(22,22)))
459460
460class DBusInterface(dbus.service.Object):461class DBusInterface(dbus.service.Object):
461 def __init__(self, ui):462 def __init__(self, ui):

Subscribers

People subscribed via source and target branches