Code review comment for lp:~fullermd/bzr/revspec-dwim

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Tue, 2009-10-27 at 06:42 +0000, Ian Clatworthy wrote:
>> Review: Needs Information
>> IIRC, I thought the consensus was that if something looks like a revno and isn't, it ought to fail rather than fall through to DWIM? This doesn't do that.
>
> That sounds undesirable to me. What if I have a tag 2.0.0 ?
>
> Rob

IIRC there was *not* a consensus. And in the interest of "he who writes
the code gets to decide" I think we can merge this as is. If we find the
DWIM not what we want, we can tweak it later.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrm9j0ACgkQJdeBCYSNAAMAOACgxUH3781d+nkYwtpvsmaYZLDn
L+UAoLr1BCCZ/h4jEtJlU/lEc5RPke6o
=BqLR
-----END PGP SIGNATURE-----

« Back to merge proposal