Code review comment for lp:~gagern/bzr/bug560030-include-bash-completion-plugin

Revision history for this message
John A Meinel (jameinel) wrote :

In a VirtualBox guest on the same hardware, I can confirm that they run better, even if they are still a bit slow:
...letion.tests.test_bashcomp.TestBashCodeGen.test_bzr_version OK 32ms
...etion.tests.test_bashcomp.TestBashCodeGen.test_command_case OK 8ms
...tion.tests.test_bashcomp.TestBashCodeGen.test_command_cases OK 1ms
...tion.tests.test_bashcomp.TestBashCodeGen.test_command_names OK 2ms
...etion.tests.test_bashcomp.TestBashCodeGen.test_debug_output OK 1ms
...ion.tests.test_bashcomp.TestBashCodeGen.test_global_options OK 3ms
...pletion.tests.test_bashcomp.TestBashCompletion.test_cmd_ini OK 685ms
...on.tests.test_bashcomp.TestBashCompletion.test_commit_dashm OK 680ms
...ion.tests.test_bashcomp.TestBashCompletion.test_global_opts OK 682ms
...n.tests.test_bashcomp.TestBashCompletion.test_init_format_2 OK 649ms
...tests.test_bashcomp.TestBashCompletion.test_init_format_any OK 676ms
...etion.tests.test_bashcomp.TestBashCompletion.test_init_opts OK 664ms
...on.tests.test_bashcomp.TestBashCompletion.test_simple_scipt OK 38ms
....tests.test_bashcomp.TestBashCompletion.test_status_negated OK 649ms
...st_bashcomp.TestBashCompletionInvoking.test_revspec_tag_all OK 985ms
...bashcomp.TestBashCompletionInvoking.test_revspec_tag_prefix OK 894ms
...pletion.tests.test_bashcomp.TestDataCollector.test_commands OK 623ms
...ion.tests.test_bashcomp.TestDataCollector.test_commit_dashm OK 8ms
...n.tests.test_bashcomp.TestDataCollector.test_global_options OK 1ms
...tion.tests.test_bashcomp.TestDataCollector.test_init_format OK 9ms
...n.tests.test_bashcomp.TestDataCollector.test_status_negated OK 6ms

----------------------------------------------------------------------
Ran 21 tests in 7.347s

However they:
 a) pass
 b) run in a reasonable speed

So I'm probably okay with this.

I'll mark this as ready, but give it a day or two in case people want to comment. (Especially on whether we want to try to run the tests on more platforms. Somebody should also probably try to test it on Mac...)

review: Approve

« Back to merge proposal