Code review comment for lp:~gagern/bzr/encodingSafeTests

Revision history for this message
Martin von Gagern (gagern) wrote :

See https://code.edge.launchpad.net/~gagern/bzr/setlocale/+merge/391 for some background on this request here: I mostly submitted the branch because it was the only thing left over from that ancient setlocale merge request. I wanted to get things closed down properly. It was vila who suggested I submit it as well.

The issues that motivated these changes have long since been dealt with, so I don't urgently need this fix. If you don't feel like merging it, then don't, I won't object (for this merge here). Only thing I'd like to avoid is rejecting the thing now and redoing the work in a few years because nobody remembers this branch.

I won't have time to code a different approach to this. So if you want it done differently, fine by me, but at least now I won't be the one implementing it.

« Back to merge proposal