Code review comment for lp:~gagern/bzr/encodingSafeTests

Revision history for this message
Martin Packman (gz) wrote :

Submitting this merge request was a good idea, there are real problems here still even after two years. What is different is the test suite now depends on testtools, and there's more of a push to get str/unicode issues sorted out. It's fine if you're not interested in working out what needs changing now as it's no longer an issue for you.

I've spoken to Robert already about making some changes to how tracebacks are stringified in testtools, and with Martin Pool about general exception printing in Bazaar. These changes are going to be a pain, but if you're okay with it I'd like to CC you on the review when I'm done.

« Back to merge proposal