Code review comment for lp:~gary/launchpad/bug-491705-hack

On January 20, 2010, Gary Poster wrote:
> Gary Poster has proposed merging lp:~gary/launchpad/bug-491705-hack into
> lp:launchpad/devel.
>
> Requested reviews:
> Canonical Launchpad Engineering (launchpad)
>
>
> This branch uses a hacked version of zc.buildout to work around the problem
> described in
> https://bugs.edge.launchpad.net/launchpad-foundations/+bug/491705 . The
> diff for this branch is below. It essentially only adds the following
> line to the top of generated scripts, such as bin/run:
>
> import encodings.utf_8 # Hack to fix sys.modules approach.
>
> This is the change that LOSAs have made manually in past deployments. It
> is not the right fix, which I am working on in
> svn://svn.zope.org/repos/main/zc.buildout/branches/gary-4 , but it gives
> us more breathing room.
>

Thanks for this safety.

 review approve
 status approved

--
Francis J. Lacoste
<email address hidden>