Code review comment for lp:~gary/launchpad/bug491705

<gary_poster> rockstar: um, so, 1600 lines are the following repetition:
<gary_poster> -#!/usr/bin/python2.5
<gary_poster> 988 +#!/usr/bin/python2.5 -S
<gary_poster> :-D
<gary_poster> please?
<rockstar> gary_poster, wow. That's a lot of python.
<gary_poster> oh yeah
<gary_poster> bac, I'm now changing my begging to rockstar. rockstar, if you can't stand it, lemme know, and I'll go beg on the foundations channel. :-)
<rockstar> gary_poster, looking at it now. It hasn't been too bad.
<gary_poster> rockstar: thank you
<rockstar> gary_poster, this seems to kill a lot of hacks we had.
<rockstar> (hacks I didn't even know about)
<gary_poster> rockstar: heh, yeah. that was a definite goal. :-)
<rockstar> gary_poster, okay, cool.
<rockstar> gary_poster, also, it looks like you killed a lot of trailing whitespace issues. Was that on purpose, or is your editor doing that?
<gary_poster> rockstar: on purpose because I tell my editor to do it. :-) If you want me to separate I will. I felt it was relatively small, but I'm obviously not in much of a bargaining position there. ;-)
<rockstar> gary_poster, well, it seems more effort to separate them than it's worth.
<gary_poster> ack
<gary_poster> thanks
<rockstar> gary_poster, however, while that does need to be done, it can cause spurious conflicts, so do so sparingly in the future plz.
<gary_poster> rockstar: ack, will do
<rockstar> I'm mostly impressed with the changes in buildout-templates/_pythonpath.py.in
<rockstar> You replaced 110 lines of code with 14 lines. :)
<rockstar> gary_poster, these are pretty invasive changes, and we're getting nigh to closing PQM time.
<rockstar> gary_poster, are you confident these changes aren't going to have explosive bugs?
<gary_poster> rockstar: ack, see last para of cover letter. Going to insert as soon as branch opens.
<rockstar> gary_poster, ah, hadn't seen that.