Code review comment for lp:~gary/lazr.restful/fix-wadl-root-template
Revision history for this message
| Gary Poster (gary) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
This branch fixes the root WADL template so that hosted files have a unique id for the DELETE methods.
It also prepares for another micro-release.
The test for this problem essentially already existed: we were validating our WADL files with lxml. However, we were using libxml2 2.6.32. Karmic uses 2.7.5 at the moment, which does validate the fact that ids should be unique. To actually test for the problem, I changed lazr.restful's buildout to use the newest versions of libxml2 and libxslt. This causes the existing test to fail without the change, and to pass once the template is fixed.
The fact that the bad template passes with older versions of libxml2 also explains why the Launchpad tests for the generated WADL passed on Hardy, but fail on Karmic.