Code review comment for lp:~garyvdm/bzr/loggraphviz

Andrew Bennetts wrote:
> Gary van der Merwe wrote:
> [...]
> >
> > Was that not because I left out the # -*- coding: utf-8 -*- line? Do
> > the unicode characters show fine in this mail?
>
> FWIW, those characters all displayed fine for me (I read mail and edit
> files using mutt and vim, both in gnome-terminal).

However, to clarify: the diff attached the original merge proposal mail
showed ? in place of the non-ascii characters. This appears to be
because Launchpad marked that attachment as encoded in ascii, rather
than utf-8.

It's not hard for me to workaround that with my mail client, but it may
be a bigger impediment for other people. And John's already reported
some trouble viewing those characters in his gvim configuration, so we
can assume a fair few other people may encounter issues too. It may be
possible to improve Launchpad to mark those attachments as utf-8, and
the issues people encounter may be easy to resolve... but unfortunately
it does mean we should tread carefully before accepting UTF-8 .py files
I think. We probably should raise the idea on the list first.

The not-ascii art is quite pretty though! So I'd definitely like us to
allow it, as it would make some comments much clearer. I'm just worried
about how disruptive it might be :/

One last quick comment: unfortunately the name “graph_viz” is a bad one
I think, because many people will assume it's associated with the very
well known graphviz software. :(