Code review comment for lp:~garyvdm/bzr/register_lazy_decorated

Revision history for this message
Robert Collins (lifeless) wrote :

Is it possible to put your test helpers 'decorated_command' and
'fake_command' into the test_commands python module? There is no need to
have them separate as far as I can tell, and if you are relying on them
not being imported when the test runs - well python won't permit you to
rely on that for a number of reasons.

'fake' as a command name is one that might actually get used someday.
How about using one of the already used test command names rather than
increasing the overlap between testing namespace and real?

I commented in another mail about the use of _builtin_cmds(); I see that
you're actually copying another use of it. How about turning the
existing use into a helper call? This will prevent code duplicatin.

I think I'd rather see *both* uses of it go away, but thats a different
proposition and I'm writing mail to the list about it now.

-Rob

« Back to merge proposal