Code review comment for lp:~garyvdm/bzr/test_no_pyqt_import

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gary van der Merwe wrote:
> Gary van der Merwe has proposed merging lp:~garyvdm/bzr/test_no_pyqt_import into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
>
> This makes test_import_tariff.TestImportTariffs.test_simple_local check that PyQt4 is not imported when bzr st is run.
>
> It also has a drive by fix to make test_import_tariff.TestImportTariffs.test_simple_local pass the new 'BZR_DISABLE_PLUGINS' and 'BZR_PLUGINS_AT' envars to the supprocess used in the test.
>
> (This should probably be move to run_bzr_subprocess, but I'll do that in another proposal.)
>

Honestly, I would be fine with always asserting this, and not just when
qbzr is installed. :)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwNY3sACgkQJdeBCYSNAANmDgCghhPZ12ZvjTvIGFYcyVHtzzB3
4PgAnA8ENYVPO0DIza575mYM1+4r/hI6
=+Uqs
-----END PGP SIGNATURE-----

« Back to merge proposal