I let John review this as he's more familiar that code.
Just a couple of comments on some details.
While you're tweaking, can you fix the lines too long (see doc/developers/HAKCING.txt Coding Style Guidelines) ?
Also, if you disagree with some comments, update them instead of deleting them (bzrlib/tests/blackbox/test_update.py).
Can you also have a look at http://www.canonical.com/contributors so we can merge your patch once it is approved ?
You may also add a NEWS entry mentioning the bugs you're addressing. Make sure you have tests reproducing them.
« Back to merge proposal
I let John review this as he's more familiar that code.
Just a couple of comments on some details.
While you're tweaking, can you fix the lines too long HAKCING. txt Coding Style Guidelines) ?
(see doc/developers/
Also, if you disagree with some comments, update them instead tests/blackbox/ test_update. py).
of deleting them (bzrlib/
Can you also have a look at http:// www.canonical. com/contributor s so we can merge your patch
once it is approved ?
You may also add a NEWS entry mentioning the bugs you're addressing.
Make sure you have tests reproducing them.