Code review comment for lp:~geser/launchpadlib/toc

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Michael.

Thanks for this fixes. This is a welcome improvement.

We may want to consider changing <xsl:template match="wadl:doc"> to create a div since we are getting inline and block content. The other option is to create a new mode called inline-copy that ignores p,div,blockquote,table,ul,ol,dl. I think the dic option is something worth trying.

Regadless, you have fixed more than requested. This branch is fine to land. If you want to ignore the <p> in <p> problem, please report a bug so that others know about this issue.

review: Approve (code)

« Back to merge proposal