Code review comment for lp:~gmb/launchpad/add-bugheatjob-table

Revision history for this message
Stuart Bishop (stub) wrote :

The id column needs to be of type 'serial PRIMARY KEY', not 'integer PRIMARY KEY'.

Otherwise the DB patch is fine. patch-2207-28-0.sql.

I wouldn't mind rejecting this though, as we appear to be building our own messaging system instead of using a messaging system. Other job tables are for longer running tasks where we need to store state during the run - we might need them even if we switched from a poll based notification to a pull based using RabbitMQ or similar. The use cases for BugJob I can imagine are just using this table as a queue.

review: Approve (db)

« Back to merge proposal