Code review comment for lp:~gmb/launchpad/add-bugheatjob-table
Revision history for this message
| Graham Binns (gmb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Tue, Jan 19, 2010 at 03:26:36AM -0000, Stuart Bishop wrote:
> Review: Approve db
> The id column needs to be of type 'serial PRIMARY KEY', not 'integer PRIMARY KEY'.
>
> Otherwise the DB patch is fine. patch-2207-
Thanks.
> I wouldn't mind rejecting this though, as we appear to be building our
> own messaging system instead of using a messaging system. Other job
> tables are for longer running tasks where we need to store state
> during the run - we might need them even if we switched from a poll
> based notification to a pull based using RabbitMQ or similar. The use
> cases for BugJob I can imagine are just using this table as a queue.
I agree. However, time constraints for getting this working (it turns
out that we need it RSN for both bug heat and fixing checkwatches) mean
that we need to go ahead with the less perfect solution.
The sooner we can get to using RabbitMQ, the better.