Code review comment for lp:~gmb/launchpad/ajax-dupefinder-has-risen-from-the-grave

Revision history for this message
Graham Binns (gmb) wrote :

This branch does the final connecting up of JS to make the Asynchronous Dupefinder stuff work.

How to test this branch (UI):

 1. Go to launchpad.dev/firefox/+filebug
 2. Enter a simple title (say, 'a') and hit "next"
 3. You should get a list of possible duplicates for that bug.
 4. You should be able to interact with those dupes in the same way as you always do (subscribe, mark as affecting you, etc).
 5. You should also be able to file a new bug if you need to in the same way as you do currently.

Issues that I'm aware of at this stage:

 1. The animations seem to happen at the wrong time, so slide_ins get played after the element has already been rendered as closed. I'm looking into this.
 2. The way that the dupes appear in the page isn't exactly pretty. I'm open to suggestions about how this should work.

« Back to merge proposal