Thanks Graham - a lot of people will be thanking you for fixing this!
It looks like it would have been the perfect opportunity to try mocker to create your test double, but I can understand that you want to get this landed ASAP.
-Michael
<gmb> noodles775: Can I get a review of https://code.edge.launchpad.net/~gmb/launchpad/no-sync-from-dupes-bug-484609/+merge/15036 please?
<noodles775> gmb: sure.
<gmb> Ta
* noodles775 has changed the topic to: on call: noodles || reviewing: gmb || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
<gmb> noodles775: I've just spotted some errors circa lines 84 and 85 of the diff - references to multiple bug watches when there's only one. I'll fix it.
<noodles775> gmb: ok, it's just comments in your doctest right? So I'll still start it now.
<gmb> noodles775: Right.
<noodles775> gmb: s/bug_watche/bugwatch on line 80 of diff?
<gmb> noodles775: Yes.
<noodles775> gmb: also, the import of transaction on line 87 is unnecessary.
<gmb> noodles775: Okidoke. I'll remove it.
Thanks Graham - a lot of people will be thanking you for fixing this!
It looks like it would have been the perfect opportunity to try mocker to create your test double, but I can understand that you want to get this landed ASAP.
-Michael
<gmb> noodles775: Can I get a review of https:/ /code.edge. launchpad. net/~gmb/ launchpad/ no-sync- from-dupes- bug-484609/ +merge/ 15036 please? irclogs. ubuntu. com || https:/ /code.edge. launchpad. net/launchpad/ +activereviews bugwatch on line 80 of diff?
<noodles775> gmb: sure.
<gmb> Ta
* noodles775 has changed the topic to: on call: noodles || reviewing: gmb || queue [] || This channel is logged: http://
<gmb> noodles775: I've just spotted some errors circa lines 84 and 85 of the diff - references to multiple bug watches when there's only one. I'll fix it.
<noodles775> gmb: ok, it's just comments in your doctest right? So I'll still start it now.
<gmb> noodles775: Right.
<noodles775> gmb: s/bug_watche/
<gmb> noodles775: Yes.
<noodles775> gmb: also, the import of transaction on line 87 is unnecessary.
<gmb> noodles775: Okidoke. I'll remove it.