Code review comment for lp:~goraxe/upstart/user_sid

Revision history for this message
Johan Kiviniemi (ion) wrote :

There’s some inconsistent use of whitespace. There also are some superfluous whitespace changes to preexisting code.

Asserting getpwnam doesn’t fail might not be the best thing to do for an init daemon.

The success of the setuid call is not verified.

« Back to merge proposal