Code review comment for lp:~guilhem-bichot/bzr/bzr-pull-verbose-shows-tip-before-pull

Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks for working on that !

This looks quite good but I've made a few tweaks at
lp:~bzr/bzr/bzr-pull-verbose-shows-tip-before-pull :
- both the revno and the revid are displayed,
- the tests use predefined revids to simplify their writing,
- I remove the test checking the *absence* of the message when not using -v
 (other tests will (or should !) fail if we do),
- I add one checking that the message is not displayed if nothing is pulled

I can add them when merging (they sounded easier to do than to describe but I think
you may be interested), but it would be easier for the second reviewer if you can merge
them to your branch, modifying them as you see fit of course and push the result
(you won't need to resubmit, just leave a comment so we know the proposal has been updated).

Also, can you complete a contributor agreement?
<http://www.canonical.com/contributors>

Finally, if the second reviewer agrees on that patch, it may be worth doing the same for push, but that can be another submission.

« Back to merge proposal