Code review comment for lp:~guilhem-bichot/bzr/bzr-pull-verbose-shows-tip-before-pull

Revision history for this message
GuilhemBichot (guilhem-bichot) wrote :

I have a second thought, and suggest that printing revno can be misleading.
A revision can have its revno changed by a pull, for example: I pull the parent branch PB; right after that the tip is the revision of revid R, of revno 10. Some time passes. Someone else merges PB into his own branch and pushes the result into PB (assume no append_revisions_only here; we do that in MySQL - which is a problem but for later). Then in PB, revision of revid R now has a dotted revno as it's not mainline anymore. It's now another revision of PB, S, which has revno 10.
Now I pull PB into my local branch; "bzr pull -v" prints that the tip is (revno 10, revid R). After the pull I find that this pull introduced a bug, I want to revert; if I do:
bzr revert -r revno:10
then I'm going to revert to S, which wasn't the intention: I wanted to revert to the tip before pulling: R.
So I suggest printing only the revid. What do you think?

« Back to merge proposal