Code review comment for lp:~guilhem-bichot/bzr/bzr-pull-verbose-shows-tip-before-pull

Revision history for this message
GuilhemBichot (guilhem-bichot) wrote :

Hi John. I'm fine with your changes. Two comments:
- do we really need to initialize "result" to None?
- the place where you print to stdout is before listing all pulled revisions (log.show_branch_change()). The output looks like:
  long list of changed files
  tip before pull
  long list of pulled revisions.
I find that the tip gets drawn in the middle of those two lists, and requires a long scrolling up the shell window in order to be found. I liked printing it after the list of pulled revisions, it was easier to spot.

« Back to merge proposal