Code review comment for lp:~guilhem-bichot/bzr/bzr-pull-verbose-shows-tip-before-pull

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

GuilhemBichot wrote:
> Hi John. I'm fine with your changes. Two comments:
> - do we really need to initialize "result" to None?
> - the place where you print to stdout is before listing all pulled revisions (log.show_branch_change()). The output looks like:
> long list of changed files
> tip before pull
> long list of pulled revisions.
> I find that the tip gets drawn in the middle of those two lists, and requires a long scrolling up the shell window in order to be found. I liked printing it after the list of pulled revisions, it was easier to spot.

I had originally put it at the very end, but there was a test that
asserts that it is before the list of new revisions (but not before the
old revs?)

We don't need to set result to None, that was done when I put the mutter
in a finally statement, and found it broke when there was a problem with
the pull.

I don't really care where the info goes, feel free to move it around. It
was more about the content of the message than where it was put.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksesu8ACgkQJdeBCYSNAAMPtwCfcRJikxb3gRNm98zSijcCVrCY
FggAn1JZtUA4BR/j9+KcwWu51uvQfIj8
=vKnt
-----END PGP SIGNATURE-----