Code review comment for lp:~guilhem-bichot/bzr/bzr-pull-verbose-shows-tip-before-pull
Revision history for this message
| John A Meinel (jameinel) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
GuilhemBichot wrote:
> I will have to look at the agreement only later - alas.
> Regarding the patch: how about enabling the printout even without -v? I find this is just a line, so not really verbose...
I believe other commands (like update) similarly print out what revision
you end up on when the command completes. I think if we incorporate that
so that we have "pulled from X to Y" as the information line, it would
be fine to include that even when -v is not supplied.
A partial concern is that computing a dotted revno is potentially
expensive on large projects. However, it isn't expected to happen often,
so the tradeoff is probably ok.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkt
EOkAnj+
=Y+ko
-----END PGP SIGNATURE-----