Code review comment for lp:~gz/bzr/add_two_in_unicode_cwd_686611

Revision history for this message
Martin Pool (mbp) wrote :

Let's unblock this.

> * ntpath.abspath returns os.getcwd (not u) with a boolean False path, until Python 2.6.5

What does "with a boolean False path" mean here? Oh, I guess it means '', and then it returns os.getcwd(); that makes sense.

I think the fix and the argument for it is pretty reasonable. I would suggest putting a comment summarizing it (or just pointing to this page) next to the osutils.has_symlinks() line.

On reflection the test there should be if platform=='win32' if we're trying to work around a specifically Windows bug?

The test is nice.

NEWS may require manual merges, but it shouldn't be inherently very difficult to merge it up.

We might not release from 2.0 again, but I don't particularly see a reason not to land it there.

So my votes is to merge it with news, and perhaps with a comment on the if statement.

review: Approve

« Back to merge proposal