Code review comment for lp:~gz/bzr/kindness_to_FAT_and_other_utime_stories_epilogue

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin [gz] wrote:
> Martin [gz] has proposed merging lp:~gz/bzr/kindness_to_FAT_and_other_utime_stories_epilogue into lp:bzr with lp:~gz/bzr/kindness_to_FAT_and_other_utime_stories as a prerequisite.
>
> Requested reviews:
> bzr-core (bzr-core)
>
>
> As per the discussion in the prerequisite branch, this change stops the diff code trying to set the date of files with undetermined timestamps to start of the unix epoch.
>
> As I didn't actually get a failure from this, I presume there's no test coverage for this path, it may not even be reachable. However, there seems to be some agreement that not setting the mtime if there's no timestamp is the right option.
>

I think is is reasonable.

John
=:->

  review: approve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvIlR8ACgkQJdeBCYSNAAOmhgCeJMRCFMQuyE2pLhmwSDRI0Yj0
4GsAoKLAL+eu1mewn9MwRVVO7fQUkT/W
=2uaX
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal