Code review comment for lp:~gz/bzr/require_unicode_committer_614593

I'm fine with it being per-repository, since each repository can have a custom CommitBuilder. Even if 99% of them are the same, catching the failure on a new repo format is good.

I would be ok if you wanted to add something like "if not isinstance(text, unicode)" to the _validate check. The code exists because revision property values (vs keys) are meant to be unicode content. And the set of unicode strings has some additional restrictions (not having '\r' in them).

(Just because it doesn't check everything it could *today* doesn't mean we can't add more checks :)