Code review comment for lp:~gz/bzr/test_ssh_client_medium_eintr__read_bytes

Revision history for this message
Martin Packman (gz) wrote :

> I'm not super keen to actually merge this because history shows that
> any test that depends on timing interactions between threads will
> intermittently fail in the future. Do you really want us to?

Your call, at the moment the code risks a random UnexpectedSuccess - which as mentioned by John AM on the list is currently harmless, but shouldn't be. When the underlying issues are fixed it'll pass, and risk wrongly passing if there's a regression, but won't cause random orange.

This kind of timing thing *is* hard to test correctly though, and it may be worth not merging just for the sanity of people reading through the module.

« Back to merge proposal