Code review comment for lp:~gz/bzr/test_ssh_client_medium_eintr__read_bytes

Revision history for this message
Martin Packman (gz) wrote :

> But isn't it valid to test for correct behaviour in the face of EINTR on all
> platforms that have EINTR?

Depends on the test. For mocks, I think it's useful, when dealing with real platform code where the outcome will either be a spurious pass or a hang depending on the details, I think it's clearer to skip. Note that os.name == "posix" covers linux, bsd (which actually has a different signal interrupt paradigm but python switches into the posix style), mac os x, solaris... Name me a platform bzr supports that you're worried about skipping the test on?

> Which interface is it that you're trying to junk?

I see you've now found:
<https://code.launchpad.net/~gz/bzr/no_until_no_eintr/+merge/19615>

« Back to merge proposal