Merge lp:~gz/bzr/use_testtools_timings_625594 into lp:bzr
Proposed by
Martin Packman
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Vincent Ladeuil | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 5467 | ||||
Proposed branch: | lp:~gz/bzr/use_testtools_timings_625594 | ||||
Merge into: | lp:bzr | ||||
Diff against target: |
48 lines (+18/-2) 2 files modified
bzrlib/tests/__init__.py (+3/-2) bzrlib/tests/test_selftest.py (+15/-0) |
||||
To merge this branch: | bzr merge lp:~gz/bzr/use_testtools_timings_625594 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincent Ladeuil | Approve | ||
Review via email: mp+36784@code.launchpad.net |
Commit message
Use testtools timing mechanisms.
Description of the change
The bzr half of the fix for bug 625594, see <lp:~gz/testtools/result_timings_forwarding_625594> for the testtools part.
Simply switches the test timing mechanism to use the api testtools provides, which enables the adaptation of subunit timestamp streams to work for bzr selftest as well without further changes.
There are some downsides here, we switch from tracking nice simple unix timestamps to datetime instances, which are harder to work with and also prevents switching to time.clock on windows for higher than 60Hz tick rate.
To post a comment you must log in.
There's a run that vila launched on babune with this change and the testtools change with a subset of the tests: babune. ladeuil. net:24842/ view/debug/ job/selftest- subset- all/93/ aggregatedTestR eport/>
<http://
Has some interesting things you can drill down to from the grouped timings, for instance, of the 10 seconds it takes to run bt.test_ workingtree_ 4 on gentoo: babune. ladeuil. net:24842/ job/selftest- subset- gentoo/ 75/testReport/ bzrlib. tests.test_ workingtree_ 4/TestWorkingTr eeFormat4/> updates_ hash_cache and test_observed_ sha1_cachable (they sleep).
<http://
There are 4 seconds each in test_commit_
Also useful for comparing the different platforms on the same suite or test.