Code review comment for lp:~henninge/launchpad/bug-128324

Looks good; I particularly like the tech debt payoff component in this branch.

It's not really explicit, but I take it the "half" of the bug that you're not solving here is the one where you mark credits as translated when you create a new POFile. If so, there really ought to be a separate bug about that. Could you see to it?

One nit: _launchpad_credits_text is a really horrible name for a function. The leading underscore isn't needed since it's not in __all__, and the name should start with a verb. Personally I'd call this compose_launchpad_credits_text.

Jeroen