Code review comment for lp:~henninge/launchpad/bug-467079

Revision history for this message
Henning Eggers (henninge) wrote :

= Bug 467079 =

The list of featured projects on the home page had a fixed length, an error which I introduced last cylcle although the old solution was bad too. It capped the first column at a fixed number and let the second grow to infinivity.

== Proposed fix ==

Dynamically calculate the length for each column according to the number of featured projects minus the top featured project. If the number is odd, make the first column one longer.

== Text ==

bin/test -vvct featuredprojects

== Demo/QA ==

Look at the homepage and see if Ubuntu and Zope are visible again ...

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/root.py
  lib/lp/registry/stories/launchpad-root/xx-featuredprojects.txt

== Pylint notices ==

lib/lp/registry/browser/root.py
    45: [F0401] Unable to import 'lazr.batchnavigator.z3batching' (No module named batchnavigator)
    509: [E1002, WindowedListBatch.__iter__] Use super on an old style class

« Back to merge proposal