Merge lp:~henninge/launchpad/bug-516739-needs-information into lp:launchpad
Proposed by
Henning Eggers
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | not available |
Merged at revision: | not available |
Proposed branch: | lp:~henninge/launchpad/bug-516739-needs-information |
Merge into: | lp:launchpad |
Diff against target: |
201 lines (+40/-25) 6 files modified
lib/canonical/launchpad/icing/style-3-0.css (+2/-0) lib/lp/translations/doc/translationimportqueue.txt (+1/-0) lib/lp/translations/interfaces/translationimportqueue.py (+6/-0) lib/lp/translations/model/translationimportqueue.py (+4/-0) lib/lp/translations/stories/importqueue/xx-translation-import-queue-filtering.txt (+1/-0) lib/lp/translations/tests/test_translationimportqueue.py (+26/-25) |
To merge this branch: | bzr merge lp:~henninge/launchpad/bug-516739-needs-information |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | code | Approve | |
Review via email: mp+18693@code.launchpad.net |
Commit message
Added Need Information status for translation import queue.
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
= Summary =
Fixes bug 516739 by introducing a new status for translation import
queue entries called "Needs Information" to request a reply from the
uploader.
== Proposed fix ==
Add the new status to the RosettaImportStatus enum and add permissions rtQueueEntry. canSetStatus.
to TranslationImpo
== Pre-implementation notes ==
Agreed with jtv that "Needs Information" is a better name than
"Incomplete" because it prompts the uploader for action. Also agreed,
that permissions should be the same as for "Approved".
== Implementation details ==
Actually, the permissions are not identical to "Approved" because "Needs
Information" can also be set if no import target has been selected.
== Tests ==
bin/test -vvct canSetSTatus
== Demo and Q/A ==
Go to the import queue as an admin and you'll see the new status in the
status picker.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: translations/ model/translati onimportqueue. py launchpad/ icing/style- 3-0.css translations/ tests/test_ translationimpo rtqueue. py translations/ interfaces/ translationimpo rtqueue. py
lib/lp/
lib/canonical/
lib/lp/
lib/lp/
== Pylint notices ==
lib/lp/ translations/ interfaces/ translationimpo rtqueue. py interface' (No module named fields' (No module named restful) declarations' (No module
10: [F0401] Unable to import 'lazr.enum' (No module named enum)
20: [F0401] Unable to import 'lazr.restful.
restful)
21: [F0401] Unable to import 'lazr.restful.
22: [F0401] Unable to import 'lazr.restful.
named restful)
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org
r7KIACgkQBT3oW1 L17igkkgCfYxNNZ GLZSIft6Z3ys8iY LolN mPAJn5oHPnoVHDH HFJFWQu93
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkt
S/UAn0a/
=OnOh
-----END PGP SIGNATURE-----