Code review comment for lp:~henninge/launchpad/bug-516739-needs-information

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =

Fixes bug 516739 by introducing a new status for translation import
queue entries called "Needs Information" to request a reply from the
uploader.

== Proposed fix ==

Add the new status to the RosettaImportStatus enum and add permissions
to TranslationImportQueueEntry.canSetStatus.

== Pre-implementation notes ==

Agreed with jtv that "Needs Information" is a better name than
"Incomplete" because it prompts the uploader for action. Also agreed,
that permissions should be the same as for "Approved".

== Implementation details ==

Actually, the permissions are not identical to "Approved" because "Needs
Information" can also be set if no import target has been selected.

== Tests ==

bin/test -vvct canSetSTatus

== Demo and Q/A ==

Go to the import queue as an admin and you'll see the new status in the
status picker.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
lib/lp/translations/model/translationimportqueue.py
lib/canonical/launchpad/icing/style-3-0.css
lib/lp/translations/tests/test_translationimportqueue.py
lib/lp/translations/interfaces/translationimportqueue.py

== Pylint notices ==

lib/lp/translations/interfaces/translationimportqueue.py
10: [F0401] Unable to import 'lazr.enum' (No module named enum)
20: [F0401] Unable to import 'lazr.restful.interface' (No module named
restful)
21: [F0401] Unable to import 'lazr.restful.fields' (No module named restful)
22: [F0401] Unable to import 'lazr.restful.declarations' (No module
named restful)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAktr7KIACgkQBT3oW1L17igkkgCfYxNNZGLZSIft6Z3ys8iYLolN
S/UAn0a/mPAJn5oHPnoVHDHHFJFWQu93
=OnOh
-----END PGP SIGNATURE-----