Thanks for making the changes discussed in IRC. The new comments in the test are much clearer, and I think you've done a Good Thing™ in moving useTempDir up from TestCaseWithFactory into lp.testing.TestCase.
The code is good, with nice use of "with." Two more tiny things, both in the docstring for is_intltool_structure:
* Say "whether" in this case, not "if." But that does make the line a bit long. Personally I prefer to phrase these descriptions as questions: "Does this source tree look like it's set up for intltool?"
* Please make it state what "tree" is supposed to be.
Thanks for making the changes discussed in IRC. The new comments in the test are much clearer, and I think you've done a Good Thing™ in moving useTempDir up from TestCaseWithFactory into lp.testing. TestCase.
The code is good, with nice use of "with." Two more tiny things, both in the docstring for is_intltool_ structure:
* Say "whether" in this case, not "if." But that does make the line a bit long. Personally I prefer to phrase these descriptions as questions: "Does this source tree look like it's set up for intltool?"
* Please make it state what "tree" is supposed to be.