Code review comment for lp:~henninge/launchpad/devel-update-copyright

Revision history for this message
Brad Crittenden (bac) wrote :

I'm glad to learn of bzr-update-copyright.

Unfortunately when we first put the copyright notice in the files we started with 2009. Using the bzr plugin will change that to use the actual years the file was touched. IANACL so I don't know which is correct but I'd like that to be a decision we make rather than whatever the tool currently writes, so I'd discourage use of the bzr plugin until we can agree.

Note the two tools do not coexist well now as Henning's uses collapsed year ranges, which we prefer, (e.g. "2009-2010") while the plugin produces a comma-separated list. Once the latter is put in the code then this tool is broken.

Perhaps the best effort would be towards improving the plugin.

I'd like for us to get one or the other b/c we spend a lot of time fixing silly copyright notices or leaving them wrong.

« Back to merge proposal