Code review comment for lp:~ian-clatworthy/bzr/411413-plugin-disable

Revision history for this message
Martin Pool (mbp) wrote :

2010/1/5 Robert Collins <email address hidden>:
> On Mon, 2010-01-04 at 22:08 +1100, Martin Pool wrote:
>> 2010/1/4 Robert Collins <email address hidden>:
>> > I suggest limiting the feature to just disabling plugins - overriding
>> > plugins is a separately requested feature and does need to be able to
>> > specify the exact path. Vincent and I have been talking about a
>> > BZR_PLUGINS_PATH syntax for doing it.
>>
>> I'd like to not add ad-hoc environment variables for things that could
>> reasonably be configured elsewhere.  Let's put it into the config
>> system and then have a way to take config from the environment.
>
> This isn't an adhoc environment variable - it already exists.

s/add variables/add features controlled by environment variables

--
Martin <http://launchpad.net/~mbp/>

« Back to merge proposal