Code review comment for lp:~ian-clatworthy/bzr/411413-plugin-disable

On Mon, 2010-01-11 at 07:48 +0000, Ian Clatworthy wrote:
>
> Another is '' (disabled) vs 'use this one if multiple exist'.
>
> I went with the latter because it was more powerful. I'm fine going
> with the first one (though it's a shame to dumb this feature down
> given your preferred alternative isn't likely to make the 2.1 IIUIC).

By default we search two places for plugins:
 - the installed library
 - homedir

and homedir wins over system installed plugins (or at least it used
too :)).

I don't see any need for specific selection of the installed library
plugin over homedir plugins via config options - just delete the homedir
plugin - uninstall it.

So it seems to really be just disabling that is really useful for the
use cases you're putting forward here (though I consider it a bug if a
plugin needs to be 'not loaded' to be unintrusive: we shouldn't be
shipping problematic plugins by default.)

-Rob