Bazaar

Code review comment for lp:~ian-clatworthy/bzr/cmds-in-userref-585667

  1. cmds-in-userref-585667
  2. Merge into bzr.dev
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

> Ian, can I ask what prompted this? It was quite deliberately changed
> to not have any commands unless you come in through the command
> handler logic.

Bug 585667. Whomever deliberately changed the semantics of this API didn't grep through the codebase to see what would break. :-( Nor did they document it in NEWS (as far as I can tell) so numerous plugins might be broken by this as well.

> Frontends *should* be deciding themselves what constitutes a built in command.

Perhaps. I'd argue that front-ends ought to have the ability to provide their own built-in commands but falling back to bzr's builtin list is reasonable behaviour. FWIW, there's no public API for loading bzr's builtin commands so clients of the API are currently left up the creek.

One alternative fix to the one suggested would be to make _register_builtin_commands() public and to call it from each and every client, e.g. autodoc_rstx.py, autodoc_man.py. Would that be better in your opinion?

« Back to merge proposal